Diddy + Tiled = black lines

Monkey Forums/Monkey Programming/Diddy + Tiled = black lines

Volker

(Posted 2013) [#1]

Using Monkey V66, Tiled V 0.7.0 and an older version of diddy.

I'm getting little black lines between the tiles (bleeding edges?) under android.
Reading through a lot of threads told me to use Image.PaddingXY
and leaving a transparent 1 Pixel border around my tiles,
but that would force me to change the diddy code.

Anyone around here who solved this?

Goodlookinguy

(Posted 2013) [#2]

I'm pretty sure this occurs when the matrix is translated to a non-whole number floating point value. I never get this issue anymore because I round translated values to the nearest whole number.

Amon	(Posted 2013) [#3]

Not sure about this but try changing mojo_imagefiltering values!

Volker

(Posted 2013) [#4]

when the matrix is translated to a non-whole number floating point value

I tried rounding all floats given to Tilemap.RenderMap(). No changes.

Not sure about this but try changing mojo_imagefiltering values!

Been there. Done that. No changes.

Goodlookinguy

(Posted 2013) [#5]

I don't use Diddy, so it might be their rendering code that has the problem. I just made a test myself using my code and it rendered without the lines between the tiles. So, I dunno.

Also, I didn't have the padding flags or filtering stuff changed. All default settings from Monkey.

therevills

(Posted 2013) [#6]

Can you supply your graphics/code? Or produce a repeatable example?

Volker

(Posted 2013) [#7]

If I take the tile example from diddy (r339) and set it to landscape,
SetScreensize(800,480) I get this effect on my both android devices.

' tile example from diddy r339
Strict

Import mojo
Import diddy

Function Main:Int()
	game = New MyGame
	Return 0
End

Global titleScreen:TitleScreen
Global gameScreen:GameScreen

Class MyGame Extends DiddyApp
	Method OnCreate:Int()
		Super.OnCreate()
		SetScreenSize(800, 480) '**** changed ****
		titleScreen = New TitleScreen
		gameScreen = new GameScreen
		titleScreen.PreStart()
		Return 0
	End
End

Class TitleScreen Extends Screen
	Method New()
		name = "Title"
	End
	
	Method Start:Void()
		game.screenFade.Start(50, false)
	End
	
	Method Render:Void()
		Cls
		DrawText "TITLE SCREEN", SCREEN_WIDTH2, SCREEN_HEIGHT2, 0.5, 0.5
		DrawText "CLICK TO PLAY", SCREEN_WIDTH2, SCREEN_HEIGHT2 + 10, 0.5, 0.5
		
		FPSCounter.Draw(0,0)
	End
	
	Method Update:Void()
		if game.mouseHit
			game.screenFade.Start(50, True, True, True)
			game.nextScreen = gameScreen
		End
	End
End

Class GameScreen Extends Screen
	Field tilemap:MyTileMap
	Field offsetX:Int, offsetY:Int
	Field str$
	
	Method New()
		name = "Game"

	End

	Method Start:Void()
		Local reader:MyTiledTileMapReader = New MyTiledTileMapReader
		Local tm:TileMap = reader.LoadMap("maps/map.xml")
		tilemap = MyTileMap(tm)
		game.screenFade.Start(50, false)
	End
	
	Method Render:Void()
		Cls
		tilemap.RenderMap(offsetX, offsetY, SCREEN_WIDTH, SCREEN_HEIGHT)
		DrawText("Touch on left or right side to scroll",10,30)
		FPSCounter.Draw(0,0)
	End
	
	Method Update:Void()
		If KeyHit(KEY_ESCAPE)
			game.screenFade.Start(50, True)
			game.nextScreen = game.exitScreen
		End
		If KeyDown(KEY_UP) Then offsetY -= 4
		If KeyDown(KEY_DOWN) Then offsetY += 4
		If KeyDown(KEY_LEFT) Then offsetX -= 4
		If KeyDown(KEY_RIGHT) Then offsetX += 4
		If TouchDown() '  **** changed ****
			If game.mouseX < 400
				offsetX -= 1
			Else
				offsetX += 1
			EndIf
		EndIf
		tilemap.UpdateAnimation(dt.frametime)
	End
End


Class MyTiledTileMapReader Extends TiledTileMapReader
	Method CreateMap:TileMap()
		Return New MyTileMap
	End
End

Class MyTileMap Extends TileMap
	Method ConfigureLayer:Void(tileLayer:TileMapLayer)
		SetAlpha(tileLayer.opacity)
	End
	
	Method DrawTile:Void(tileLayer:TileMapTileLayer, mapTile:TileMapTile, x:Int, y:Int)
		mapTile.image.DrawTile(x, y, mapTile.id, 0, 1, 1)
	End
End

Amon	(Posted 2013) [#8]

It may be better to try the latest version of diddy. You're using quite an old version.

Volker

(Posted 2013) [#9]

Thanks all, with newest Monkey, newest diddy and disabling MOJO_IMAGE_FILTERING_ENABLED the black lines are gone.

But as I expected a whole bunch of new construction yards have opened.
EDIT: What the hell happened with List.Remove(object)?

Nobuyuki

(Posted 2013) [#10]

List.Remove has been depreciated. Use Either RemoveEach or RemoveFirst...

MikeHart

(Posted 2013) [#11]

Or node.Remove, which is the fastest method anyway.

Volker

(Posted 2013) [#12]

It's back in V71b. And hopefully stays where it is :-|