iOS GLES20 LoadImageData crash

Monkey Forums/Monkey Bug Reports/iOS GLES20 LoadImageData crash

nullterm

(Posted 2015) [#1]

Using glTexImage2D to load a texture and I was getting a crash in modules/opengl/native/gles20.ios.cpp, function LoadImageData.

	free( src );

The code is trying to free "src" memory, but src was previously incremented as the image data was read.

case 4:
	for( y=0;y<height;++y ){
		memcpy( dst,src,width*4 );
		dst+=width*4;
		src+=pitch;
	}
	break;

I fixed locally by adding a srcStart that is passed to free and fixes the iOS crash.

BBDataBuffer *LoadImageData( BBDataBuffer *buf,String path,Array<int> info ){

	int width=0,height=0,format=0;
	unsigned char *src=BBIosGame::IosGame()->LoadImageData( path,&width,&height,&format );
	if( !src ) return 0;

	unsigned char *srcStart = src;
	
	if( !buf->_New( width*height*4 ) ) return 0;
	unsigned char *dst=(unsigned char*)buf->WritePointer();

	int y=0,pitch=width*format;
		
	switch( format ){
	case 3:
		for( y=0;y<height;++y ){
			for( int x=0;x<width;++x ){
				*dst++=*src++;
				*dst++=*src++;
				*dst++=*src++;
				*dst++=255;
			}
			src+=pitch;
		}
		break;
	case 4:
		for( y=0;y<height;++y ){
			memcpy( dst,src,width*4 );
			dst+=width*4;
			src+=pitch;
		}
		break;
	}
	
	free( srcStart );
	
	if( info.Length()>0 ) info[0]=width;
	if( info.Length()>1 ) info[1]=height;
	
	return buf;
}

marksibly

(Posted 2015) [#2]

Oh dear, stupid bug - thanks for finding it!

nullterm

(Posted 2015) [#3]

No worries! One of those sweet, innocent, little bugs that love to slip under the radar.

Glad I could stomp it. : ) Haven't had this much fun coding for YEARS since I found out about monkey a few weeks ago, happy to help improve it even in the tiniest way.