OSX: horiz scrolling tweak for bbSystemEmitOSEvent

BlitzMax Forums/BlitzMax Module Tweaks/OSX: horiz scrolling tweak for bbSystemEmitOSEvent

N	(Posted 2010) [#1]

The current Mac OS implementation of bbSystemEmitOSEvent neglects to handle horizontal scrolling (e.g., trackpad scrolling) when handling the ScrollWheel event. So, here's a fixed version of the routine:

brl.mod/system.mod/system.macos.m

void bbSystemEmitOSEvent( NSEvent *event,NSView *view,BBObject *source ){
	int inView;
	NSEventType type;
	NSString *characters;
	int ev=0,data=0,x=0,y=0,oldMods,mask;
	float f;

	type=[event type];

	switch( type ){
	case NSKeyDown:
		if( data=bbSystemTranslateKey( [event keyCode] ) ){
			ev=[event isARepeat] ? BBEVENT_KEYREPEAT : BBEVENT_KEYDOWN;
			bbSystemEmitEvent( ev,source,data,bbSystemTranslateMods(mods),0,0,&bbNullObject );
		}
		characters=[event characters];
		if( [characters length]!=1 ) return;
		data=[characters characterAtIndex:0];
		if( data>=0xf700 && data<=0xf8ff ) return;
		ev=BBEVENT_KEYCHAR;
		data=bbSystemTranslateChar( data );
		break;
	case NSKeyUp:
		data=bbSystemTranslateKey( [event keyCode] );
		if( !data ) return;
		ev=BBEVENT_KEYUP;
		break;
	case NSFlagsChanged:
		oldMods=mods;
		mods=[event modifierFlags];
		deltaMods=mods^oldMods;
		if( deltaMods & (mask=LSHIFTMASK) ) data=KEY_LSHIFT;
		else if( deltaMods & (mask=RSHIFTMASK) ) data=KEY_RSHIFT;
		else if( deltaMods & (mask=LCTRLMASK) ) data=KEY_LCONTROL;
		else if( deltaMods & (mask=RCTRLMASK) ) data=KEY_RCONTROL;
		else if( deltaMods & (mask=LALTMASK) ) data=KEY_LALT;
		else if( deltaMods & (mask=RALTMASK) ) data=KEY_RALT;
		else if( deltaMods & (mask=LSYSMASK) ) data=KEY_LSYS;
		else if( deltaMods & (mask=RSYSMASK) ) data=KEY_RSYS;
		if( !data ) return;
		ev=(mods & mask) ? BBEVENT_KEYDOWN : BBEVENT_KEYUP;
		break;
	case NSLeftMouseDown:
	case NSRightMouseDown:
	case NSOtherMouseDown:
		inView=mouseViewPos( view,&x,&y );
		if( !inView ) return;
		setMouseView( view,x,y,source );
		capturedView=mouseView;
		ev=BBEVENT_MOUSEDOWN;
		data=(type==NSLeftMouseDown) ? 1 : (type==NSRightMouseDown ? 2 : 3);
		break;
	case NSLeftMouseUp:
	case NSRightMouseUp:
	case NSOtherMouseUp:
		inView=mouseViewPos( view,&x,&y );
		if( !inView && !capturedView ) return;
		capturedView=0;
		ev=BBEVENT_MOUSEUP;
		data=(type==NSLeftMouseUp) ? 1 : (type==NSRightMouseUp ? 2 : 3);
		break;
	case NSMouseMoved:
	case NSLeftMouseDragged:
	case NSRightMouseDragged:
	case NSOtherMouseDragged:
		inView=mouseViewPos( view,&x,&y );
		setMouseView( inView ? view : 0,x,y,source );
		if( !inView && !capturedView ) return;
		ev=BBEVENT_MOUSEMOVE;
		data=(type==NSLeftMouseDragged) ? 1 : (type==NSRightMouseDragged ? 2 : (type==NSOtherMouseDragged ? 3 : 0));
		break;
	case NSScrollWheel:
		inView=mouseViewPos( view,&x,&y );
		if( !inView && view!=capturedView ) return;
		ev=BBEVENT_MOUSEWHEEL;
		f=[event deltaX];
		x=f>0 ? ceil(f) : floor(f);
		f=[event deltaY];
		data=y=f>0 ? ceil(f) : floor(f);
		// remove the 'data=' bit if you don't mind breaking backwards compatibility
		break;
	default:
		return;
	}
	bbSystemEmitEvent( ev,source,data,bbSystemTranslateMods(mods),x,y,&bbNullObject );
}

Also, not sure why this puts the delta in the data field in the first place, but I left a comment about the backwards compatibility bit in the code if you don't care about breaking a few things (I'm not sure what those things are, but I'm sure someone has something that would be broken without also making data the Y delta).

Space_guy

(Posted 2010) [#2]

Works very well.

UByte

(Posted 2011) [#3]

Found this code useful for something I'm working on but I should add the following modification is also needed.

maxgui.mod/cocoamaxgui.mod/cocoa.macos.m

static int EmitMouseEvent( NSEvent *event,void *handle ){
	if(([event type] == NSScrollWheel) && ([event deltaX] == 0) && ([event deltaY] == 0)) return 0;
	if(!HaltMouseEvents) return maxgui_cocoamaxgui_EmitCocoaMouseEvent( event,handle );
}

Without this tweak horizontal scroll movements are only reported when a vertical scroll occurs.

shinkiro1

(Posted 2012) [#4]

Has somebody an up to date code of this (first post)?

It seems some things have changed in this section so I can't apply the tweak.

shinkiro1

(Posted 2012) [#5]

Bump.
I have tried to implement this but it always crashes (because I don't know anything about obj c).

Could somebody be genrous enough and share an up to date tweak?

Space_guy

(Posted 2012) [#6]

Hmm. I did this a few months back. I dont think much has changed since then or?

shinkiro1

(Posted 2012) [#7]

Well, I couldn't find the exact code which to replace and I fiddled around with it too long.
Btw, all of the code is in the public domain anyway, so one can post the whole module code.

So, could somebody share a working copy please?

shinkiro1

(Posted 2012) [#8]

Bump again. Is there nobody that could upload a working version?
Would really need this. Thanks.