OOP Coding Questions (Suggestions)

BlitzMax Forums/BlitzMax Programming/OOP Coding Questions (Suggestions)

FBEpyon (Posted 2012) [#1]

Hello All, I have been re-writing my code for a MineCraft like engine and I would like you opinion of my code, I have done it two different ways, and I was wanting to know which you think is the better approach. Module Based: Type TBlock Field x:Float Field y:Float Field z:Float Field v:Byte Field vx:Float[8] Global List:TList = CreateList() Method Set:TBlock(x:Float, y:Float, z:Float, v:Byte) If Self.x = x and Self.y = y and Self.z = z Self.v = v EndIf End Method Method Get:Byte(x:Float, y:Float, z:Float) If Self.x = x and Self.y = y and Self.z = z Return Self.v EndIf End Method Method Add_Block:TBlock(x:Float, y:Float, z:Float, s:TSurface) If Self.x = x and Self.y = y and Self.z = z 'Vertex Adding Self.vx[0] = AddVertex(s, x-.5, y+.5, z-.5) Self.vx[1] = AddVertex(s, x+.5, y+.5, z-.5) Self.vx[2] = AddVertex(s, x-.5, y-.5, z-.5) Self.vx[3] = AddVertex(s, x+.5, y-.5, z-.5) Self.vx[4] = AddVertex(s, x-.5, y+.5, z+.5) Self.vx[5] = AddVertex(s, x+.5, y+.5, z+.5) Self.vx[6] = AddVertex(s, x-.5, y-.5, z+.5) Self.vx[7] = AddVertex(s, x+.5, y-.5, z+.5) EndIf End Method Method Add_Side:TBlock(x:Float, y:Flost, z:Float, s:String, s:TSurface) If Self.x = x and Self.y = y and Self.z = z 'Triangle Code Select s Case "LEFT" AddTriangle s, Self.vx[0], Self.vx[4], Self.vx[6] AddTriangle s, Self.vx[0], Self.vx[6], Self.vx[2] Case "TOP" AddTriangle s, Self.vx[1], Self.vx[5], Self.vx[4] AddTriangle s, Self.vx[1], Self.vx[0], Self.vx[4] Case "BACK" AddTriangle s, Self.vx[5], Self.vx[7], Self.vx[4] AddTriangle s, Self.vx[4], Self.vx[7], Self.vx[6] Case "RIGHT" AddTriangle s, Self.vx[5], Self.vx[1], Self.vx[7] AddTriangle s, Self.vx[1], Self.vx[3], Self.vx[7] Case "BOTTOM" AddTriangle s, Self.vx[3], Self.vx[7], Self.vx[6] AddTriangle s, Self.vx[3], Self.vx[6], Self.vx[2] Case "FRONT" AddTriangle s, Self.vx[3], Self.vx[0], Self.vx[1] AddTriangle s, Self.vx[3], Self.vx[2], Self.vx[0] End Select Endif End Method Method Del_Block:TBlock(x:Float, y:Float, z:Float) If Self.x = x and Self.y and Self.z = z ListRemove Self,TBlock.List EndIf End Method Method Build:TBlock(c:TChunk) For Local x:Int = 0 to 16-1 ; For Local y:int = 0 to 128-1 ; For Local z:int = 0 to 16-1 If Get_Data(x,y,z) = 1 Build_Block(b,x,y,z,c.surf) If x>0 If Get_Data(x-1,y,z) = 0 Add_Side(b,x,y,z,"LEFT",c.surf) EndIF EndIf If y>0 If Get_Data(x,y-1,z) = 0 Add_Side(b,x,y,z,"TOP",c.surf) EndIF EndIf If z>0 If Get_Data(x,y,z-1) = 0 Add_Side(b,x,y,z,"BACK",c.surf) EndIF EndIf If x<128-1 If Get_Data(x+1,y,z) = 0 Add_Side(b,x,y,z,"RIGHT",c.surf) EndIF EndIf If y<128-1 If Get_Data(x,y+1,z) = 0 Add_Side(b,x,y,z,"BOTTOM",c.surf) EndIF EndIf If z<128-1 If Get_Data(x,y,z+1) = 0 Add_Side(b,x,y,z,"FRONT",c.surf) EndIF Endif If x=0 Add_Side(b,x,y,z,"LEFT",c.surf) If Get_Data(x+1,y,z) = 0 Add_Side(b,x,y,z,"RIGHT",c.surf) EndIF EndIf If y=0 Add_Side(b,x,y,z,"BOTTOM",c.surf) If Get_Data(x,y+1,z) = 0 Add_Side(b,x,y,z,"TOP",c.surf) EndIF EndIf If z=0 Add_Side(b,x,y,z,"FRONT",c.surf) If Get_Data(x,y,z+1) = 0 Add_Side(b,x,y,z,"BACK",c.surf) EndIF EndIf If x=128-1 Add_Side(b,x,y,z,"RIGHT",c.surf) If Get_Data(x-1,y,z) = 0 Add_Side(b,x,y,z,"LEFT",c.surf) EndIF EndIf If y=128-1 Add_Side(b,x,y,z,"TOP",c.surf) If Get_Data(x,y-1,z) = 0 Add_Side(b,x,y,z,"BOTTOM",c.surf) EndIF EndIf If z=128-1 Add_Side(b,x,y,z,"BACK",c.surf) If Get_Data(x,y,z-1) = 0 Add_Side(b,x,y,z,"FRONT",c.surf) EndIF EndIf EndIf Next ; Next ; Next End Method End Type Function Based: Type TBlock Field x:Float Field y:Float Field z:Float Field v:Byte Field vert:Float[8] Global List:TList = CreateList() End Type Function Set_Data(b:TBlock, x:Float, y:Float, z:Float, v:Byte) If b.x = x and b.y = y and b.z = z b.v = v EndIf End Function Function Get_Data:Byte(b:TBlock, x:Float, y:Float, z:Float) If b.x = x and b.y = y and b.z = z Return b.v EndIf End Function Function Add_Block(b:TBlock, x:Float, y:Float, z:Float, s:TSurface) If b.x = x and b.y = y and b.z = z 'Vertex Adding b.vert[0] = AddVertex(s, x-.5, y+.5, z-.5) b.vert[1] = AddVertex(s, x+.5, y+.5, z-.5) b.vert[2] = AddVertex(s, x-.5, y-.5, z-.5) b.vert[3] = AddVertex(s, x+.5, y-.5, z-.5) b.vert[4] = AddVertex(s, x-.5, y+.5, z+.5) b.vert[5] = AddVertex(s, x+.5, y+.5, z+.5) b.vert[6] = AddVertex(s, x-.5, y-.5, z+.5) b.vert[7] = AddVertex(s, x+.5, y-.5, z+.5) EndIf End Function Function Add_Side(b:TBlock, x:Float, y:Flost, z:Float, s:String, s:TSurface) If b.x = x and b.y = y and b.z = z 'Triangle Code Select s Case "LEFT" AddTriangle s, b.vert[0], b.vert[4], b.vert[6] AddTriangle s, b.vert[0], b.vert[6], b.vert[2] Case "TOP" AddTriangle s, b.vert[1], b.vert[5], b.vert[4] AddTriangle s, b.vert[1], b.vert[0], b.vert[4] Case "BACK" AddTriangle s, b.vert[5], b.vert[7], b.vert[4] AddTriangle s, b.vert[4], b.vert[7], b.vert[6] Case "RIGHT" AddTriangle s, b.vert[5], b.vert[1], b.vert[7] AddTriangle s, b.vert[1], b.vert[3], b.vert[7] Case "BOTTOM" AddTriangle s, b.vert[3], b.vert[7], b.vert[6] AddTriangle s, b.vert[3], b.vert[6], b.vert[2] Case "FRONT" AddTriangle s, b.vert[3], b.vert[0], b.vert[1] AddTriangle s, b.vert[3], b.vert[2], b.vert[0] End Select Endif End Function Function Del_Block(b:TBlock, x:Float, y:Float, z:Float) If b.x = x and b.y and b.z = z ListRemove b,TBlock.List EndIf End Function Function Build_Blocks(c:TChunk, b:TBlock) For Local x:Int = 0 to 16-1 ; For Local y:int = 0 to 128-1 ; For Local z:int = 0 to 16-1 If Get_Data(x,y,z) = 1 Build_Block(b,x,y,z,c.surf) If x>0 If Get_Data(x-1,y,z) = 0 Add_Side(b,x,y,z,"LEFT",c.surf) EndIF EndIf If y>0 If Get_Data(x,y-1,z) = 0 Add_Side(b,x,y,z,"TOP",c.surf) EndIF EndIf If z>0 If Get_Data(x,y,z-1) = 0 Add_Side(b,x,y,z,"BACK",c.surf) EndIF EndIf If x<128-1 If Get_Data(x+1,y,z) = 0 Add_Side(b,x,y,z,"RIGHT",c.surf) EndIF EndIf If y<128-1 If Get_Data(x,y+1,z) = 0 Add_Side(b,x,y,z,"BOTTOM",c.surf) EndIF EndIf If z<128-1 If Get_Data(x,y,z+1) = 0 Add_Side(b,x,y,z,"FRONT",c.surf) EndIF Endif If x=0 Add_Side(b,x,y,z,"LEFT",c.surf) If Get_Data(x+1,y,z) = 0 Add_Side(b,x,y,z,"RIGHT",c.surf) EndIF EndIf If y=0 Add_Side(b,x,y,z,"BOTTOM",c.surf) If Get_Data(x,y+1,z) = 0 Add_Side(b,x,y,z,"TOP",c.surf) EndIF EndIf If z=0 Add_Side(b,x,y,z,"FRONT",c.surf) If Get_Data(x,y,z+1) = 0 Add_Side(b,x,y,z,"BACK",c.surf) EndIF EndIf If x=128-1 Add_Side(b,x,y,z,"RIGHT",c.surf) If Get_Data(x-1,y,z) = 0 Add_Side(b,x,y,z,"LEFT",c.surf) EndIF EndIf If y=128-1 Add_Side(b,x,y,z,"TOP",c.surf) If Get_Data(x,y-1,z) = 0 Add_Side(b,x,y,z,"BOTTOM",c.surf) EndIF EndIf If z=128-1 Add_Side(b,x,y,z,"BACK",c.surf) If Get_Data(x,y,z-1) = 0 Add_Side(b,x,y,z,"FRONT",c.surf) EndIF EndIf EndIf Next ; Next ; Next End Function

SystemError51 (Posted 2012) [#2]

I prefer using methods in all my types. That way everything that belongs to a type stays inside the type. I use functions only as a global access point, for functions that should be externally available. The functions then reroute the requested action into the correct method of the type.

Yasha (Posted 2012) [#3]

It's literally just a matter of aesthetics. Unless you make use of polymorphism (at which point things take a massive swerve in a different direction), there is no logical difference between the two approaches. Which looks more elegant to you? There's a case to be made for both. First one saves you some typing though. It also means that you can more easily add subclasses later, should you want them.

FBEpyon (Posted 2012) [#4]

My main goal of this is trying to get rid of arrays in the building of the blocks and chunks.. Thanks for looking at this, if you have any other suggestions let me know..