Why isn't this code working?

Blitz3D Forums/Blitz3D Programming/Why isn't this code working?

Amanda Dearheart

(Posted 2012) [#1]

Ok genuises, why isn't this code working the way I want it to?
Under the Game function, the images are placed on the screen like I want,
But under the Game1 function, when I want the user to click the mouse1 button, the image is supposed to be placed where the mouse cursor is, but no such luck. Anyone care to give me a shot at an answer!


Dim a(10, 10)
Dim b(10, 10)
Dim Cells(101)

Global cellB, cellR, cellY  ; main graphic images
Global SWidth = 1024
Global SHeight = 768

; so far the main functions in the game
StartUp
LoadGraphics
;Game
Game1

end

Function Game1()
	Repeat
	
		Mx = MouseX()
		My = MouseY()
		Debugcon (str(Mx), str(My))
		Flip		
		if MouseDown(1) then PlaceImage(Cells(1), Mx, My)   ; Debugcon ("retvalue : " + retvalue$, "max : " + str$(max), "xyl : " + str$(xyl))

	Forever
End Function

Function StartUp()
	
	Graphics 1024, 768, 32
	SetBuffer BackBuffer()
	
End Function

Function LoadGraphics()
	
	cellB = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell black.jpg")
	cellR = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell red.jpg")
	cellY = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell yellow.jpg")


	; copy the images that we loaded in LoadGraphics into the Cells array so
	; that we can have 100 copies of the same mesh
	For x = 1 to 100
		Cells(x) = CopyImage(cellY)
	Next

	
End Function

Function Game()
	
	
	; this is a test function to display the meshes in a grid 10 x 10
	Repeat
	For x = 1 to 10
		For y = 1 to 10 
			f = ((10 * (x - 1)) + y)  ;  convert x,y 1 - 11 to array 1 - 100
			PlaceImage(Cells(f), x, y)
			; Debugcon("x = " + str$(x), "y = " + str$(y))
			Flip
		Next
	Next
	Forever
	
	
	
End Function

Function Evaluate()
	Dim a(10, 10)
	Dim b(10, 10)
	For x = 2 to 9
		For y = 0 to 9
			c = 0
			if a(x - 1,y - 1) = 1 then c = c + 1
			if a(x - 1, y) = 1 then c = c + 1
			if a(x - 1, y + 1)= 1 then c = c + 1
			if a(x, y - 1) = 1 then c = c + 1
			if a(x, y + 1) = 1 then c = c + 1
			if a(x + 1, y - 1) = 1 then c = c + 1
			if a(x + 1, y) = 1 then c = c + 1
			if a(x + 1, y + 1) = 1 then c = c + 1
			if a(x, y) = 1 and (c <> 3 and c <> 2) then b(x, y) = 0
			if a(x, y) = 0 and c = 3 then b(x, y) = 1
		Next 
	Next  
End Function

Function PlaceImage(Image, x, y)
	 x3 = 300 + (x * 35)   ;  100  - y start of grid, 35 - width of image
	 y3 = 200 + (y * 35)   ;  100  - y start of grid, 35 - width of image
	 DrawImage Image, x3, y3, 0
	 Flip
End Function

Function Debugcon(Msg1$, Msg2$ = "empty", Msg3$ = "empty too")
	viewport 800, 500, 200, 200
	ClsColor 0, 0, 255
	Cls
	Text 800, 500, Msg1$
	Text 800, 530, Msg2$
	Text 800, 560, Msg3$
	viewport 0, 0, SWidth, SHeight	 
End Function

virtlands

(Posted 2012) [#2]

Well the code is very complex, and I'd like to help....

I'm curious as to why you're calling the following meshes,
Didn't you mean to say "100 copies of the same image" ?

Your code:
; copy the images that we loaded in LoadGraphics into the Cells array so
; that we can have 100 copies of the same mesh
For x = 1 to 100
Cells(x) = CopyImage(cellY)
Next

I think you'll need to redo the whole thing and try to make it simpler.

I doubt it's necessary to make 100 copies of the same image.
It would probably be better to just use that 1 image and then you can
draw it several times in different positions.

Last edited 2012

Last edited 2012

K	(Posted 2012) [#3]

Okay, Miss

Mx = MouseX()
My = MouseY()
Debugcon (Str(Mx), Str(My))
Flip		
If MouseDown(1) Then PlaceImage(Cells(1), Mx, My)   ; Debugcon ("retvalue : " + retvalue$, "max : " + str$(max), "xyl : " + str$(xyl))

Swap the fourth and fifth lines. PlaceImage() is getting called after the backbuffer has already been flipped,so the order never gets sent to the screen.
Regarding what VirtLands said, I would reccomend a 'Image' type, i.e.

Type Image
Field x,y,im
end type

Then your Dim Cells(101) becomes Dim Cells.Image(101).
So then PlaceImage() becomes a function that actually clones a reference to the image rather than the image itself, as in...

;semi-pseudo code
Function PlaceImage.Image(im,x,y)
I.image=New Image
I\im=im
I\x=x
I\y=y
Return I
End Function
;Used like...
Delete Cells(101)
Cells(101)=PlaceImage
;Update to draw
Function DrawCells()
 For k=0to 100
  If Cells(k)<>Null
   DrawImage Cells(k)\im,Cells(k)\x,Cells(k)\y
  Eendif
 Next
End Function

For that matter, the Array could be dispensed with, but that depends on how you want your code to be.

K	(Posted 2012) [#4]

Ah, there seems to be more at issue. Errm, first you need to get rid of all those flips, you only really need one, at the end of your loop.
I'll get back to you...
EDIT: Ahah, your DebugCon() func seems to be the culprit, get rid of the viewport stuff,or...move all your DebugCon() calls to after you have drawn your other gfx.

Last edited 2012

Amanda Dearheart

(Posted 2012) [#5]

Thanks to all of you for your help guys.
I'll work on them as soon as I get home!

As for the cells topic, that piece of code is only temporary as it was placed there to help me set up a grid section for the game!

It will be dispensed with when the game is completed!

K	(Posted 2012) [#6]

In that case, switching to 2d-in-3d would have erased this problem.
Apparently, multiple viewport changes don't agree with blitz's 2d workings, which is a little disappointing... I had always assumed viewport could be used as a sort of scissor.

_PJ_	(Posted 2012) [#7]

AFAIK Viewport doesn't crop buffers or anything like that, it simply places a limit on where any 2d draw commands (DrawImage, Text, Circle, Line etc.) content will actually be written to the buffer, As if "placing a template/windoiw over the front of the buffer"

Amanda Dearheart

(Posted 2012) [#8]

OK guys, I've updated my code to what I finally really wanted.
I've deleted all references to meshes, removed the grid test block, as I done testing that section of code, changed the 3d angle to 2d, as I couldn't get the 3d version to work the way I wanted.

However the code still doesn't work, witness the code in the SetPattern function


Dim a(10, 10)
Dim b(10, 10)

Dim Cpy$(4)   ;    used for copyright info in DisplayTitle function

Global cellB, cellR, cellY, blank  ; main graphic images
Global Screen_Width = 1024
Global Screen_Height = 768
Global Title                ; handle for title graphic

; so far the main functions in the game

Game

end


Function StartUp()
	
	Graphics 1024, 768, 32
	SetBuffer BackBuffer()
	
End Function

Function LoadGraphics()
	
	Title = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\life.jpg")
	
	cellB = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell black.jpg")
	cellR = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell red.jpg")
	cellY = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell yellow.jpg")
	blank = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\blank.jpg")
	
	
	Zero = LoadFont("Saved by Zero",18,False,True,False)
	SetFont Zero
	
End Function

Function Game()
	
	StartUp
	LoadGraphics
	demo = DisplayTitle()
	SetPattern(demo)
	
	Main(demo)
	
	;EndGame
		
End Function

Function DisplayTitle()

	Iw = ImageWidth(Title)
	CenterX = Screen_Width/2 - Iw/2
	DrawImage Title, CenterX, 0

	Cpy$(1) = "Adapted by Amanda Dearheart"
	Cpy$(2) = "Based on Life by John Conway"
	Cpy$(3) = "(C) 2013 Crazy Scorpion"
	For M = 1 to 3
		
		Tw = Len(Cpy$(M))
		CenterX = Screen_Width/2 - Tw * 6
		y3 = 400 + (M * 25)
		Text CenterX, y3, Cpy$(M)
	Next
	Flip
	
	d = TimerPause(5000, True)
	cls
	
	Return d
End Function

Function SetPattern(demostate)
	
	if demostate = True then
		SeedRnd MilliSecs()
		For x = 2 to 9
				For y = 0 to 9
					a(x, y) = rnd(0, 1)
					if a(x, y) = 1 then PlaceImage(cellY, x, y)
					;b(x, y) = a(x, y)
				Next	
		Next
	Else
		done = False
		Repeat
			;Mx = MouseX()
			;My = MouseY()
			PlaceImage(cellY, MouseX(), MouseY())
			Flip
			if done = True then exit
		Forever
	End if
	
End Function

Function Main(demostate)

	if demostate = true then
		
		Repeat

			if KeyHit(1) then exit
			
			G = G + 1   ;   used for  generation

			GenCon(100, 420, G)
		
			Evaluate
			
				
			Flip

		Forever
			
	EndIf
	
End Function

Function EndGame()
	
End Function

Function GenCon(Top, Left, value)
	
	Gen$ = "Generation " + str(value)  
	viewport Left, Top, 200, 40
			
	cls
	Text Left, Top, Gen$
			
	viewport 0, 0, Screen_Width, Screen_Height
	
End Function

Function Evaluate()

	For x = 2 to 9
		For y = 2 to 9
			c = 0
			if a(x - 1,y - 1) = 1 then c = c + 1
			if a(x - 1, y) = 1 then c = c + 1
			if a(x - 1, y + 1)= 1 then c = c + 1
			if a(x, y - 1) = 1 then c = c + 1
			if a(x, y + 1) = 1 then c = c + 1
			if a(x + 1, y - 1) = 1 then c = c + 1
			if a(x + 1, y) = 1 then c = c + 1
			if a(x + 1, y + 1) = 1 then c = c + 1
			if a(x, y) = 1 and (c <> 3 and c <> 2) then b(x, y) = 0
			if a(x, y) = 0 and c = 3 then b(x, y) = 1

			
			if b(x, y) = 1 then PlaceImage(cellY, x, y)
			if b(x, y) = 0 then PlaceImage(blank, x, y)
			
		Next 
	Next  
	
End Function

Function PlaceImage(Image, x, y)
		 
	 x3 = 300 + (x * 35)   ;  100  - y start of grid, 35 - width of image
	 y3 = 200 + (y * 35)   ;  100  - y start of grid, 35 - width of image
	 DrawBlock Image, x3, y3, 0
	 Flip
	 
End Function

Function Debugcon(Msg1$, Msg2$ = "empty", Msg3$ = "empty too")
	
	viewport 800, 500, 200, 200
	ClsColor 0, 0, 255
	Cls
	Text 800, 500, Msg1$
	Text 800, 530, Msg2$
	Text 800, 560, Msg3$
	viewport 0, 0, Screen_Width, Screen_Height	 
	
End Function

Function TimerPause(time# = 5000, TrapKM = False)
	
	now = MilliSecs()
	demo = True
	While MilliSecs() < now + time#
		if TrapKM = True then
			kb = GetKey()
			mb = GetMouse()
		EndIf
		
		if kb > 0 or mb > 0  then demo = False : exit
	Wend
	
	Return demo
	
End Function

Last edited 2012

Last edited 2012

_PJ_	(Posted 2013) [#9]

There's a few issues here.
The "done" variable in the SetPattern function will NEVER become "True" in this loop and therefore the loop will never exit.

You will need something somewhere between Repeat and Forever which can set done to TRUE when the right conditions arise.
Becaus of this, the Main function will never get to run.

Using Rnd(0,1) Will practically NEVER return a 0 or 1 since Rnd returns a floating point value from 0.000000 to 1.0000000 so there's a practically infinite number of values in between!
I recommend using Rand(0,1) if you just want a simple 50/50 chance of Integer 0 or 1 appearing.

Incidentally, you don't need to use SeedRnd every time, just once at the start of the code ought to set the seed for a good randomisation.

I've made a few changes which I hope should help give you a start on fixing the rest of the program.


Dim a(10, 10)
Dim b(10, 10)

Dim Cpy$(4)   ;    used for copyright info in DisplayTitle function

Global cellB, cellR, cellY, blank  ; main graphic images
Global Screen_Width = 1024
Global Screen_Height = 768
Global Title                ; handle for title graphic

Global StartTime

; so far the main functions in the game

Game

End


Function StartUp()
	
	Graphics 1024, 768, 32
	SetBuffer BackBuffer()
	
	StartTime=MilliSecs()	
	SeedRnd StartTime
End Function

Function LoadGraphics()
	
	
	Title = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\life.jpg")
	
	cellB = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell black.jpg")
	cellR = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell red.jpg")
	cellY = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\cell yellow.jpg")
	blank = LoadImage("C:\Documents and Settings\HP_Administrator\My Documents\workspace\life\media\blank.jpg")
	
	
	Zero = LoadFont("Saved by Zero",18,False,True,False)
	SetFont Zero
	
End Function

Function Game()
	
	StartUp
	LoadGraphics
	demo = DisplayTitle()
	SetPattern(demo)
	
	Main(demo)
	
	;EndGame
		
End Function

Function DisplayTitle()

	Iw = ImageWidth(Title)
	CenterX = Screen_Width/2 - Iw/2
	DrawImage Title, CenterX, 0

	Cpy$(1) = "Adapted by Amanda Dearheart"
	Cpy$(2) = "Based on Life by John Conway"
	Cpy$(3) = "(C) 2013 Crazy Scorpion"
	For M = 1 To 3
		
		Tw = Len(Cpy$(M))
		CenterX = Screen_Width/2 - Tw * 6
		y3 = 400 + (M * 25)
		Text CenterX, y3, Cpy$(M)
	Next
	Flip
	
	Return (MilliSecs-StartTime)<5000
End Function

Function SetPattern(demostate)

	If demostate = True Then

		For x = 2 To 9
				For y = 0 To 9
					a(x, y) = Rand(0, 1)
					If a(x, y) = 1 Then PlaceImage(cellY, x, y)
					;b(x, y) = a(x, y)
				Next	
		Next
	Else
		done = False
		Repeat
			;Mx = MouseX()
			;My = MouseY()
			PlaceImage(cellY, MouseX(), MouseY())
			Flip
			If done = True Then Exit
		Forever
	End If
	
End Function

Function Main(demostate)

	If demostate = True Then
		
		Repeat

			If KeyHit(1) Then Exit
			
			G = G + 1   ;   used for  generation

			GenCon(100, 420, G)
		
			Evaluate
			
				
			Flip

		Forever
			
	EndIf
	
End Function

Function EndGame()
	
End Function

Function GenCon(Top, Left, value)
	
	Gen$ = "Generation " + Str(value)  
	Viewport Left, Top, 200, 40
			
	Cls
	Text Left, Top, Gen$
			
	Viewport 0, 0, Screen_Width, Screen_Height
	
End Function

Function Evaluate()

	For x = 2 To 9
		For y = 2 To 9
			c = 0
			If a(x - 1,y - 1) = 1 Then c = c + 1
			If a(x - 1, y) = 1 Then c = c + 1
			If a(x - 1, y + 1)= 1 Then c = c + 1
			If a(x, y - 1) = 1 Then c = c + 1
			If a(x, y + 1) = 1 Then c = c + 1
			If a(x + 1, y - 1) = 1 Then c = c + 1
			If a(x + 1, y) = 1 Then c = c + 1
			If a(x + 1, y + 1) = 1 Then c = c + 1
			If a(x, y) = 1 And (c <> 3 And c <> 2) Then b(x, y) = 0
			If a(x, y) = 0 And c = 3 Then b(x, y) = 1

			
			If b(x, y) = 1 Then PlaceImage(cellY, x, y)
			If b(x, y) = 0 Then PlaceImage(blank, x, y)
			
		Next 
	Next  
	
End Function

Function PlaceImage(Image, x, y)
		 
	 x3 = 300 + (x * 35)   ;  100  - y start of grid, 35 - width of image
	 y3 = 200 + (y * 35)   ;  100  - y start of grid, 35 - width of image
	 DrawBlock Image, x3, y3, 0
	 Flip
	 
End Function

Function Debugcon(Msg1$, Msg2$ = "empty", Msg3$ = "empty too")
	
	Viewport 800, 500, 200, 200
	ClsColor 0, 0, 255
	Cls
	Text 800, 500, Msg1$
	Text 800, 530, Msg2$
	Text 800, 560, Msg3$
	Viewport 0, 0, Screen_Width, Screen_Height	 
	
End Function

Function TimerPause(time# = 5000, TrapKM = False)
	
	now = MilliSecs()
	demo = True
	While MilliSecs() < now + time#
		If TrapKM = True Then
			kb = GetKey()
			mb = GetMouse()
		EndIf
		
		If kb > 0 Or mb > 0  Then demo = False : Exit
	Wend
	
	Return demo
	
End Function

Amanda Dearheart

(Posted 2013) [#10]

Thanks _PJ_

Your input is appreciated, however I have solved the problem to this code about a week ago! but I do appreciate your input!

thanks for the advice about the RND(0,1) suggestion!