Array index out of bounds?

Blitz3D Forums/Blitz3D Programming/Array index out of bounds?

Guy Fawkes (Posted 2012) [#1]

Can someone please tell me why array index is out of bounds, when it's clearly not? Here's the media & source files: http://www.mediafire.com/?btghxqav03ua2t6 I couldn't make a demo this time, because it's complaining about the array -.- Sorry Guys.... Thanks guys! :)

Yasha (Posted 2012) [#2]

Where are you getting the error? This actually works perfectly when I run it, debug mode or not. I had no trouble creating an exe and using all functions listed at the top of the screen.

Guy Fawkes (Posted 2012) [#3]

This line: Map(X,Y)=ReadInt(FI) in both loops

Yasha (Posted 2012) [#4]

Can you post instructions on replicating the error? (i.e. where exactly do we have to place objects, switch to G mode, load, save, whatever... in sequence?)

Guy Fawkes (Posted 2012) [#5]

Alright. Well. 1st thing I did was went into the level editor. (editor1.bb) I then drew a couple of test tiles in random places on the green background (or map), then saved the map by pressing F1. Then I closed the level editor. Opened it, pressed F2 to load the map, I THEN took lvl1.map that the level editor generated, and put it in the Game folder, and it worked fine in the LEVEL EDITOR. BUT in the GAME for some reason, I'm getting that stupid array index is out of bounds error, when it clearly is NOT >< Here's the level editor: http://www.mediafire.com/download.php?btghxqav03ua2t6 Let me know if you need more information! :) Thanks, Yasha :) Last edited 2012

Yasha (Posted 2012) [#6]

Oh, whoops. I only thought to test the editor - didn't realise there was meant to be a game as well. The other three files are Hud.bb, scancodes.bb and testlevel.bb. Going out on a limb and assuming scancodes isn't the game, neither of the other two work due to a missing Include "Globals.bb". So you might want to update the download...

Guy Fawkes (Posted 2012) [#7]

O, ignore that... Here's the new files, 2 zip files contained in 1 master zip file. just extract the main zip file, then extract the other 2. I have included both the game AND the level editor in this update. with ONLY the files needed for them both to run. http://www.mediafire.com/?sgn80045htdl4aw Thanks, Yasha! :)

Guy Fawkes (Posted 2012) [#8]

Wtf? I reset IDEAL, and the stupid thing works o.O... That is SO weird... Anyways, now that it works, can u tell me why it's not drawing the tiles like it should?

Yasha (Posted 2012) [#9]

...well actually I can tell you what the error is in the version you just uploaded. Classic one: your Dim statement comes after your call to Load. So initially the array has no elements. Blitz is a bit weird this way in that globally declared names are visible throughout the program no matter where the declaration happens, but the initialisation (either sizing an array or putting things into a global) happens "in sequence" as you go down the main scope. As for the other bit... it draws what I quickly drew out in the editor (once the Dim statement is moved above the call to Load). What's going wrong there? Last edited 2012

Guy Fawkes (Posted 2012) [#10]

Ok, I replaced the code for the Game. Here's the fix for Dim, but for some reason, I can't get it to draw the tiles in the right places: Graphics 800,600,0,2 SetBuffer BackBuffer() ;this is just were i call the scan codes for the keys i will be using Const LeftKey=203 Const RightKey=205 Const UpKey=200 Const DownKey=208 Global offsetx Global offsety ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;Make sure this graphics points to the Ztileset.bmp Image! Global tiles = LoadAnimImage("gfx\Ztileset.bmp",32,32,0,10) MaskImage tiles, 255, 0, 255 Global Map_Tiles_Width,Map_Tiles_Height Dim Map(1000,1000) Dim MapCol(1000,1000) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;But level name here! Load("lvl1.map") Map_Length=50 Map_Height=50 Global playerx = GraphicsWidth()/2-Map_Length/2 Global playery = GraphicsHeight()/2-Map_Height/2 ;Added Needed Variables MapWidth = Map_Length*32 + 1 MapHeight = Map_Height*32 + 1 PlayerSize = 32 ;// While Not KeyDown(1) Cls PlayerSpeed=10 If KeyDown(RightKey) Then playerx = playerx + PlayerSpeed If KeyDown(LeftKey) Then playerx = playerx - PlayerSpeed If KeyDown(DownKey) Then playery = playery + PlayerSpeed If KeyDown(UpKey) Then playery = playery - PlayerSpeed If playerx<=0 Then playerx=0 If playery<=0 Then playery=0 If playerx>=MapWidth-PlayerSize Then playerx=MapWidth-PlayerSize If playery>=MapHeight-PlayerSize Then playery=MapHeight-PlayerSize offsetx=GraphicsWidth()/2-(playerx+PlayerSize/2) offsety=GraphicsHeight()/2-(playery+PlayerSize/2) If offsetx>0 Then offsetx=0 If offsetx<MapWidth*-1+GraphicsWidth() Then offsetx=MapWidth*-1+GraphicsWidth() If offsety>0 Then offsety=0 If offsety<MapHeight*-1+GraphicsHeight() Then offsety=MapHeight*-1+GraphicsHeight() ; // Draw ou our array, replace Rect with appropriate DrawImage For x=0 To Map_Length For y=0 To Map_Height DrawImage tiles,x*32+offsetx,y*32+offsety,Map(X,Y) Next Next Color 0, 255, 0 Oval playerx+offsetx, playery+offsety, 32, 32, 1 Color 255, 255, 255 Color 255, 255, 255 Text GraphicsWidth()/2, GraphicsHeight()/2, "offsetx: "+offsetx, 1, 1 Text GraphicsWidth()/2, GraphicsHeight()/2+20, "Map_Length: "+Map_Length, 1, 1 Text GraphicsWidth()/2, GraphicsHeight()/2+40, "playerx: "+playerx, 1, 1 Text GraphicsWidth()/2, GraphicsHeight()/2+60, "playery: "+playery, 1, 1 Flip Wend Function Load(FileName$) ;Open the file FI=ReadFile(FileName$) ;If the File failed to open, return False (also known as 0) If FI=0 Then Return 0 ;Set X & Y's maximum amount SX=32 SY=24 ;Set the Global values of X,Y Map_Tiles_Width=SX Map_Tiles_Height=SY ;Begin Map Read For Y=0 To Map_Tiles_Height For X=0 To Map_Tiles_Width Map(X,Y)=ReadInt(FI) Next Next ;Begin MapCol Read For Y=0 To Map_Tiles_Height For X=0 To Map_Tiles_Width MapCol(X,Y)=ReadInt(FI) Next Next ;Release the Handle of the file CloseFile(FI) ;Return True for a completed load! (also known as 1) Return 1 End Function It's not drawing my tiles at ALL o.o Even though it reads the file Last edited 2012

Yasha (Posted 2012) [#11]

Once again, this seems to work fine for me. Loads my smiley face map correctly.

Guy Fawkes (Posted 2012) [#12]

wtf?... o.o Why wont it load my Ztileset.bmp map? :/

Guy Fawkes (Posted 2012) [#13]

Ok, it seems to work now.. I don't know WHAT it is with IDEAL. Now... One more question, then this is complete :) How can I make a map the same size as the map in the game? Is there a way I can make the level editor allow for scrolling with the arrow keys so that I can create a map the same size as the one in the game? :)

Yasha (Posted 2012) [#14]

All you have to do is have an offset for the current top left corner of the editor view. Draw the tiles "For x = xOffset to screenXsize + xOffset" and "For y = yOffset to screenYsize + yOffset" or something like that, and make sure that the maximum value for the offsets is "maxXsize - screenXsize" and the equivalent for Y. You might want to make your map sizes variable and load them from the saved map file, too; just make them the first two ints saved to the file, and read before the tile loading loop.

Guy Fawkes (Posted 2012) [#15]

How do I get the offset for the current top left corner of the editor?

Guy Fawkes (Posted 2012) [#16]

Here's what I have so far: Include "scancodes.bb" Graphics 1024,768,0,2 AppTitle "Platform editor v2.0" SetBuffer BackBuffer() AutoMidHandle False ;Images placed by their top left TFormFilter 0 ;32 Dim map(32,24) Dim mapcol(32,24) Dim mapData(32,24) Global mapx = 32 Global mapy = 24 Global mapx1 = 0 Global skypos Global gridon = False Global mapview = 1024 Global tiles = LoadAnimImage("gfx/Ztileset.bmp",32,32,0,10) Global sky = LoadImage("gfx\sky1.bmp") MaskImage tiles,255,0,255 TileImage sky Global cursorx,cursory Global gx,gy Global currenttile=1 Global rpik,rpik2 Global rcol,rcol1,rcol2 Global mode=1 Global coltype=1 Const erasetile = 0 fill() Global X1 = 0 Global Y1 = 0 ; Main While Not KeyHit(1) Cls If KeyDown(k_left) X1 = X1 - 1 If X1 < -1000 X1 = -1000 EndIf EndIf If KeyDown(k_right) X1 = X1 + 1 If X1 > 10 X1 = 10 EndIf EndIf If KeyDown(k_up) Y1 = Y1 - 1 If Y1 < 0 Y1 = 0 EndIf EndIf If KeyDown(k_down) Y1 = Y1 + 1 If Y1 > 36 Y1 = 36 EndIf EndIf sky() update() grid() control() info() Flip Wend Function control() If mode=1 ; If KeyDown(k_left) = mapx Then mapx = mapx+1 : mapx1 = mapx1 +1 If KeyHit(12) And mode=1 Then currenttile=currenttile-1 If KeyHit(13) And mode=1 Then currenttile=currenttile+1 If KeyHit(34) If gridon=True gridon=False Else gridon=True EndIf EndIf If currenttile<0 Then currenttile=9 If currenttile>9 Then currenttile=0 If KeyHit(46) Then mode=2 gx=MouseX()/32 gy=MouseY()/32 Color 256,0,0 Line MouseX()-10,MouseY(),MouseX()+10,MouseY() Line MouseX(),MouseY()-10,MouseX(),MouseY()+10 If MouseDown(1) And gx < 32 And gy < 24 Then map(gx,gy)=currenttile If MouseDown(2) And gx < 32 And gy < 24 Then map(gx,gy)=0 EndIf If mode=2 If KeyHit(12) And mode=2 Then coltype=coltype-1 If KeyHit(13) And mode=2 Then coltype=coltype+1 If coltype<1 Then coltype=1 If coltype>2 Then coltype=2 Color 256,0,0 Line MouseX()-10,MouseY(),MouseX()+10,MouseY() Line MouseX(),MouseY()-10,MouseX(),MouseY()+10 gx=MouseX()/32 gy=MouseY()/32 If KeyHit(46) Then mode=1 If MouseDown(1) And gx < 32 And gy < 24 And coltype=1 Then mapcol(gx,gy)=1 If MouseDown(1) And gx < 32 And gy < 24 And coltype=2 Then mapcol(gx,gy)=2 If MouseDown(2) And gx < 32 And gy < 24 Then mapcol(gx,gy)=0 EndIf If KeyHit(59) save("lvl1.map") supersave("lvl1_decrypted.map") EndIf If KeyHit(60) load("lvl1.map") EndIf If KeyHit(203) mapview=mapview+1 EndIf If KeyHit(208) EndIf End Function Function update() If mode=1 For x=0 To mapx For Y=0 To mapy DrawImage tiles,X1+x*32,Y1+y*32,map(x,y) Next Next Color 0,0,0 Rect 0,0,40,40,1 DrawImage tiles,3,3,currenttile EndIf If mode=2 For x=0 To mapx For Y=0 To mapy DrawImage tiles,x*32,y*32,map(x,y) If mapcol(x,y)=1 Color 0,0,0 Rect x*32,y*32,32,32,0 EndIf If mapcol(x,y)=2 Color 255,0,0 Rect x*32,y*32,32,32,0 EndIf Next Color 0,0,0 Rect 0,0,40,40,1 If coltype=1 Color 0,0,0 Rect 3,3,32,32,1 EndIf If coltype=2 Color 255,0,0 Rect 3,3,32,32,1 EndIf Next EndIf End Function Function sky() TileBlock sky,skypos,0 skypos=skypos+1 End Function Function info() If mode=1 Text 100,0,"Press C to change to collision mode leftclick = place tile rightclick = remove tile + and - change tiles" Text 100,20,"F1 to save - F2 to load Unfortunatly it only saves as (lvl1.lvl) SOZ" Text 100,40,"Press D to change to data mode Press G for grid mode " EndIf If mode=2 Text 100,0,"Press C to change to scenery mode leftclick = place collision rightclick = remove collision" EndIf End Function Function save(filename$) f=WriteFile(filename$) For y=0 To 24 For x=0 To 32 WriteInt f,map(x,y) Next Next For y=0 To 24 For x=0 To 32 WriteInt f,mapcol(x,y) Next Next CloseFile f End Function Function supersave(filename$) f=WriteFile(filename$) For y=0 To 24 For x=0 To 32 WriteLine f, "TileNumber: "+map(x,y) Next Next For y=0 To 24 For x=0 To 32 WriteLine f,"CollisionTileNumber: "+mapcol(x,y) Next Next CloseFile f End Function Function load(filename$) f=OpenFile(filename$) For y=0 To 24 For x=0 To 32 i=ReadInt(f) map(x,y)=i Next ;x Next ;y For y=0 To 24 For x=0 To 32 i=ReadInt(f) mapcol(x,y)=i Next ;x Next ;y CloseFile f End Function Function grid() If gridon=True For x=0 To mapx For y=o To mapy Rect x*32,y*32,32,32,0 Next Next EndIf End Function Function fill() For x=0 To mapx For y=0 To mapy map(x,y)=5 Next Next End Function