Layered Picking with Mouse issues.

Blitz3D Forums/Blitz3D Beginners Area/Layered Picking with Mouse issues.

Omnicode

(Posted 2013) [#1]

Hello, I have an issue I hope could be solved. I have successfully coded a full-purpose inventory system using types, Basically the type represents an array of all slots. each slot displays data based on its image value etc. creating the illusion of an item being there to the user though its just simple munipulation of the slot_image, which is stored in a global AnimatedImage of the inventory. However, my issue is when trying to access a specific slot upon mousehit(1) based on its x,y (rectsoverlap function): it is either delayed by half of a second then registers or requires multi-clicking (spamming) to actually register. I realize it may just be an issue of how im accessing the slots, but id like to know how to access a specific type without switching it from the top of the "stack", the bottom or just moving it from its position in que of each type-list. So if anyone can offer any advice id gladly listen. my fps is not a factor, the inventory system runs fluently, it works fine with the Mousedown(1) but it updates too fast to effectively place objects one-by-one. Contact me here or by email. Thanks.

Omnicode

(Posted 2013) [#2]

Here's the function that runs the main inventory.

Function Run_Slots()
If KeyHit(19) Then Section_Tab=Section_Tab+1
If Section_Tab>3 Then Section_Tab=0
	Color 255,255,255
	For B.Bag=Each Bag
		If B\Show_Status=1
			If B\Moveable=1
				Select B\State
					Case 0
						B\x=MouseX()-25
						B\y=MouseY()-80
					Case 1
						B\x=B\x
						B\y=B\y
				End Select
			EndIf
			
			
			If B\Name$="Inventory"
			 Select B\Status
				Case 0
					B\x=B\x+16
				Case 1
					B\x=B\x-16
			 End Select
			  If B\x>GraphicsWidth()-95 Then B\x=GraphicsWidth()-95
			  If B\x<GraphicsWidth()-305 Then B\x=GraphicsWidth()-305
				DrawImage Inv_Image,B\x+50,B\y+25-200,Section_Tab
			  Select Section_Tab
			    Case 2 ;Stats tab
                     Text 50+B\x,B\y-150,"Energy:"+P\Energy#+"/"+P\Max_Energy#
			    Case 3 ;Spell tab
   						For Spll.Spell_Tab=Each Spell_Tab
      						If Spll\Required_Level<=P\Level
       							DrawImage Spll\Slot_Img,Spll\x+B\x,Spll\y+B\y
       							DrawImage Spll\Image,Spll\x+B\x,Spll\y+B\y

       							If RectsOverlap(MouseX(),MouseY(),5,5,Spll\x+B\x,Spll\y+B\y,32,32)
          							DrawImage Spell_Sel,Spll\x+B\x,Spll\y+B\y
       							    Text B\x+200,B\y-100,"Spell:"+Spll\Name$,True,False
       							EndIf

       							If RectsOverlap(MouseX(),MouseY(),5,5,Spll\x+B\x,Spll\y+B\y,32,32) And KeyDown(2)=True
          							Assign_Spell(Spll\image,Spll\Name$,Spll\id,1)
       							EndIf

       							If RectsOverlap(MouseX(),MouseY(),5,5,Spll\x+B\x,Spll\y+B\y,32,32) And KeyDown(3)=True
         						    Assign_Spell(Spll\image,Spll\Name$,Spll\id,2)
       							EndIf

       							If RectsOverlap(MouseX(),MouseY(),5,5,Spll\x+B\x,Spll\y+B\y,32,32) And KeyDown(4)=True
          							Assign_Spell(Spll\image,Spll\Name$,Spll\id,3)
      					        EndIf

       							If RectsOverlap(MouseX(),MouseY(),5,5,Spll\x+B\x,Spll\y+B\y,32,32) And KeyDown(5)=True
          							Assign_Spell(Spll\image,Spll\Name$,Spll\id,4)
       							EndIf

      						Else
       							DrawImage Spll\Slot_Img,Spll\x+B\x,Spll\y+B\y
       							DrawImage X_Image,Spll\x+B\x,Spll\y+B\y
      						EndIf
  					 Next
			  End Select
			EndIf
			
			For S.Slot=Each Slot
				If S\Parent$=B\Name$
				  If S\Amount>=64 Then S\Amount=64:S\Stackable=0
					Color 255,255,255
					Select Section_Tab
					Case 0
					 DrawImage Slot_Image,B\x+S\x,B\y+S\y
					 If S\Tpe$="_25500"
						DrawImage S\Slot_Img,B\x+S\x,B\y+S\y
					 Else
						If S\Status$="Empty"
							DrawImage S\Slot_Img,B\x+S\x,B\y+S\y
						EndIf
					 EndIf
					Case 1
					 If S\ID<2204
					  DrawImage Slot_Image,B\x+S\x,B\y+S\y
					  If S\Tpe$="_25500"
						DrawImage S\Slot_Img,B\x+S\x,B\y+S\y
					  Else
						If S\Status$="Empty"
							DrawImage S\Slot_Img,B\x+S\x,B\y+S\y
						EndIf
					  EndIf
					 EndIf
					End Select
				EndIf
					
					
					Color 255,0,0 
					
					Select S\Status$
						Case "Empty"
							S\img_id=0
							S\Stackable=1
							S\Amount=0
							S\Durability#=0
						Default
							Color 255,255,255
						If Section_Tab<2
					           DrawImage item_image(0),B\x+S\x,B\y+S\y,s\img_id
							If S\Amount>0 And S\Status$<>"Empty" And Section_Tab<2
								text_x=B\x+s\x+25-Len(S\Amount)*FontWidth()*.5
								text_y=B\y+s\y+Inv_Size-FontHeight()
								Text text_x+10,text_y,S\Amount
							EndIf
						       If S\Durability#>=1
						        Tpe$=Right$(S\Status$,6)
						        If Tpe$<>"_25500"
						        	d=(S\Durability#/100)
							    	Durability#=(S\Durability#/100)*Inv_Size
							    	Color (111)*d,(196)*d,(77)*d
									Rect (B\x+S\x)+2,(S\y+B\y)+2,Durability#-4,5,1
									Color 30,30,30
									Rect (B\x+S\x)+2,(S\y+B\y)+2,Inv_Size-4,5,0
							    Else
							        S\Durability#=1
							    EndIf
							   EndIf
						EndIf
					End Select
					
					Select Sel\Status$
						Case "Unequipped/Not Inventory"
						  If Section_Tab<2
							If RectsOverlap(MouseX(),MouseY(),5,5,B\x+S\x,B\y+S\y,Inv_Size,Inv_Size)
								Color 255,255,255
								
								If S\Status$<>"Empty"
									Select Right$(S\Status$,9)
										Default
											Temp$=Replace(S\Status$,Right$(S\Status$,9),"")
											MouseSelectionString$="Move ->"+Temp$
									End Select
								EndIf
								
								If MouseHit(1)=True : FlushMouse() ;Picking up an item
								 If S\Tpe$<>"_25564"
								  If S\Status$<>"Empty"
									Sel\Name$=S\Status$
									Sel\S_item=S\img_id
									Sel\id=S\id
									Sel\Amount=S\Amount
									Sel\Stored_4=S\Durability#
									Sel\Durability#=S\Durability#
									Sel\Status$="Full"
									S\Status$="Empty"
									Task$="Moving"
								   EndIf
								  Else
								   If S\Status$<>"Empty"
									Sel\Name$=S\Status$
									Sel\S_item=S\img_id
									Sel\id=S\id
									Sel\Amount=S\Amount
									Sel\Stored_4=S\Durability#
									Sel\Durability#=S\Durability#
									Sel\Status$="Full"
									S\Status$="Empty"
									Task$="Moving"
									;Equip_Item()
									If Craft1$<>"X" Then Clear_Invent_Slot(2204)
									If Craft2$<>"X" Then Clear_Invent_Slot(2205)
									If Craft3$<>"X" Then Clear_Invent_Slot(2206)
									If Craft4$<>"X" Then Clear_Invent_Slot(2207)
									If Craft5$<>"X" Then Clear_Invent_Slot(2208)
									If Craft6$<>"X" Then Clear_Invent_Slot(2209)
									If Craft7$<>"X" Then Clear_Invent_Slot(2210)
									If Craft8$<>"X" Then Clear_Invent_Slot(2211)
									If Craft9$<>"X" Then Clear_Invent_Slot(2212)
								  EndIf
								 EndIf
								EndIf
								;If MouseDown(2)=True ;Split a stack.
                                 ;  If S\Status$<>"Empty"
                                  ;    If S\Amount>1
                                   ;      Sel\Name$=S\Status$
									;     Sel\S_item=S\img_id
									 ;    Sel\id=S\id
                                      ;   Sel\Amount=Floor#(S\Amount#/2)
									   ;  Sel\Stored_4=S\Durability#
									    ; Sel\Durability#=S\Durability#
                                         ;S\Amount=Ceil#(S\Amount#/2)
                                         ;Sel\Status$="Full"
                                         ;Task$="Moving"
                                         ;S.Slot=First Slot
                                      ;Else
                                       ;  Sel\Name$=S\Status$
									    ; Sel\S_item=S\img_id
									     ;Sel\id=S\id
                                         ;Sel\Amount=S\Amount
									     ;Sel\Stored_4=S\Durability#
									     ;Sel\Durability#=S\Durability#
                                         ;S\Amount=Sel\Amount
                                         ;S\Status$="Empty"
                                         ;Sel\Status$="Full"
                                         ;Task$="Moving"
                                         ;S.Slot=First Slot
                                      ;EndIf
                                   ;EndIf
								;EndIf
							EndIf
						   EndIf
						Case "Full"
						   If Section_Tab<2
							If RectsOverlap(MouseX(),MouseY(),5,5,B\x+S\x,B\y+S\y,Inv_Size,Inv_Size)
								If S\Status$<>"Empty"
								  If Check=0
									Select Right$(S\Status$,9)
										Default
											TempS1$=Replace(S\Status$,Right$(S\Status$,9),"")
									End Select
									Select Right$(S\Status$,9)
										Default
											TempS2$=Replace(Sel\Name$,Right$(Sel\Name$,9),"")
									End Select
									MouseSelectionString$="Switch --->"+TempS2$+" --->"+TempS1$
								  EndIf
							    EndIf
								If MouseHit(2)=True
								     If Task$="Moving" Or Task$="Switching" And S\Tpe$="_25500"
								       If Sel\Amount>=1
								         If S\Status$="Empty"
                                        	S\Status$=Sel\Name$
                                        	S\Amount=S\Amount+1
								        	Sel\Amount=Sel\Amount-1
											S\img_id=Sel\S_item
											S\Stackable=1
											S.Slot=First Slot
											If Sel\Amount<1
											 Sel\S_Item=0
											 Sel\Amount=0
											 Sel\Stored_1$="(Null)"
											 Sel\Stored_2=0
											 Sel\Stored_3=0
											 Sel\Stored_3=0
											 Check=0
											 Sel\Status$="Unequipped/Not Inventory"
											EndIf
										ElseIf S\Status$=Sel\Name$
                                        	S\Status$=Sel\Name$
                                        	S\Amount=S\Amount+1
								        	Sel\Amount=Sel\Amount-1
											S\img_id=Sel\S_item
											S\Stackable=1
											S.Slot=First Slot
											If Sel\Amount<1
											 Sel\S_Item=0
											 Sel\Amount=0
											 Sel\Stored_1$="(Null)"
											 Sel\Stored_2=0
											 Sel\Stored_3=0
											 Check=0
											 Sel\Status$="Unequipped/Not Inventory"
											EndIf
										EndIf
                                       Else
											Sel\S_Item=0
											Sel\Amount=0
											Sel\Stored_1$="(Null)"
											Sel\Stored_2=0
											Sel\Stored_3=0
											S\Stackable=1
											Check=0
											Sel\Status$="Unequipped/Not Inventory"
                                       EndIf
								     EndIf
								   EndIf						
								
								If MouseHit(1)=True
								    ;S\Status$
								    ;S\Tpe$
								    ;Sel\Name$
								    ;S\Amount
								    ;Sel\S_item
								    ;S\img_id
								    ;Sel\Status
								    ;Sel\Stored_1-3
								    ;Check
								    ;Sel\Status$
									If S\Status$="Empty" And Section_Tab<2
										If S\Tpe$=Right$(Sel\name$,6) Or S\Tpe$="_25500" And S\Tpe$<>"_25564"
											S\Status$=Sel\Name$
											Equip_Item()
											If S\img_id=0 And Task$="Moving"
												S\img_id=Sel\S_item
												S\Amount=Sel\Amount
												S\Durability#=Sel\Stored_4
												DebugLog "Regular Move Occured "+S\Status$+ " "+S\Id
                   ;DO_EQUIPMENT_CHECK
												
												Sel\Status$="Unequipped/Not Inventory"
											Else
												If S\Status$="Empty"
												Else
													Task$="Moving" : DebugLog "Switch mode"
													S\img_id=Sel\Stored_2 ;Images
													If Check=1
														DebugLog "Switched Item Amount: "+Sel\Name$+":"+Sel\Stored_3
														S\Amount=Sel\Stored_3 ;Amounts
														S\Durability#=Sel\Stored_4
														;S\img_id=Sel\Stored_2
													    Sel\Stored_1$="(Null)"
													    Sel\Stored_2=0
														Sel\Status$="Unequipped/Not Inventory"
														Check=0
													EndIf
													DebugLog "Item Put into "+S\id+ " slot."
												EndIf
											EndIf
										EndIf
									Else; And S\img_id<>Sel\S_item
										If Check=0
											If S\Status$<>Sel\Name$
											   If S\Tpe$=Right$(Sel\name$,6) Or S\Tpe$="_25500" And S\Tpe$<>"_25564"
													Task$="Switching"
              ;Cycling. fml.. (this took the longest to perfect) basically SWAPPING ever value into the mouse and then back out.
													
													Sel\Stored_1$=S\Status$ ;Names
													S\Status$=Sel\Name$
													Sel\Name$=Sel\Stored_1$
													
													Sel\Stored_2=S\img_id ;Images
													S\img_id=Sel\S_item
													Sel\S_item=Sel\Stored_2
													
													Sel\Stored_3=S\Amount ;Amounts
													S\Amount=Sel\Amount
													Sel\Amount=Sel\Stored_3
													
													Sel\Stored_4=S\Durability#
													S\Durability#=Sel\Durability#
													Sel\Durability#=Sel\Stored_4
													
													
													Check=1
													DebugLog "Item Data Switched: "+S\Status$+ " ID:"+S\img_id
												EndIf
											  Else
											    DebugLog "Switching x2"
												
												If S\Status$=Sel\Name$ And S\Durability#=Sel\Stored_4
												   If S\Tpe$="_25500" And S\Tpe$<>"_25564"
													DebugLog "Items Stacked: "+Sel\Name$+":"+S\Status$
													S\Amount=S\Amount+Sel\Amount
                    ;Clear Stored Item that is going to be stacked.
													Sel\Stored_1$="(Null)"
													Sel\Stored_2=0
													Sel\Amount=0
													Sel\S_Item=0
													Sel\Status$="Unequipped/Not Inventory"
												   Else
												     Sel\Amount=Sel\Amount+S\Amount
												     Clear_Invent_Slot(2204)
													 Clear_Invent_Slot(2205)
													 Clear_Invent_Slot(2206)
													 Clear_Invent_Slot(2207)
													 Clear_Invent_Slot(2208)
													 Clear_Invent_Slot(2209)
												   EndIf
												EndIf
										      EndIf
											Else
												If Check=1
												    Sel\Stored_1$=S\Status$ ;Names
													S\Status$=Sel\Name$
													Sel\Name$=Sel\Stored_1$
													
													
													Sel\Stored_2=S\img_id ;Images
													S\img_id=Sel\S_item
													Sel\S_item=Sel\Stored_2

													
													Sel\Stored_3=S\Amount ;Amounts
													S\Amount=Sel\Amount
													Sel\Amount=Sel\Stored_3
													
												    Sel\Stored_4=S\Durability#
													S\Durability#=Sel\Durability#
													Sel\Durability#=Sel\Stored_4
												EndIf
										  EndIf
									EndIf
							    EndIf
							EndIf
						  EndIf
					End Select
				Color 255,255,255
			Next
		EndIf
	Next
End Function

I've already tinkered around trying to fix the issue with it so if there's any be-nine factors don't judge.

Also, disregard any spell stuff. Here's how the inventory is laid out.
-Bag
-Slots in bags
-Slot handling

-Access Bag called "inventory"
Items all have a dignified string assigning them certain properties.
"_25500" : MISC. can go in any slot besides equipment.
"_25501.." : is Sword,PickAxe,Axe,Shovel

Examples:
"Mystical Logs018_25500"
"Wooden Sword019_25501"
"name of item$|Imageid#|type$"

Just further clarification.

Kryzon

(Posted 2013) [#3]

I suggest you rewrite it; That's certainly what I'd do if I had this amount of code and didn't know where the bug might be.

And also, separate the rendering part from the logic part. It doesn't matter if you're going to have to run through an all-items loop twice (one for logic, one for rendering). It makes the code that much clear, and demands from you a more organized way of dealing with data. There's no price in that.

Function Run_Slots()
;Only logic\update code.
End Function

Function Render_Slots()
;Only render\drawing code.
End Function

EDIT: I also think all these assignment blocks such as...

Sel\Name$=S\Status$
Sel\S_item=S\img_id
Sel\id=S\id
Sel\Amount=S\Amount
Sel\Stored_4=S\Durability#
Sel\Durability#=S\Durability#
Sel\Status$="Full"
S\Status$="Empty"
Task$="Moving"

...should be converted to a single function call. That is, something like SetSelect(Sel.slot, S.slot).
You know from which object you're retrieving data and to which you're outputting it, so you can spare all these lines with a single one for the sake of clearness\privacy:

SetSelect( Sel, S )
Task$ = "Moving"

MCP	(Posted 2013) [#4]

I think it's highly likely your repeated use of MouseHit(),MouseX(),MouseY() within your function's For...Next loop that's giving you problems. These functions should only be Read from ONCE per frame (especially MouseHit) which is why response is laggy and you're having to spam your mouse buttons. See blitz docs... MouseHit. It is Blitz's Flip() command that is actually responsible for updating mouse and keyboard events via Windows PeekMessage function so the above is most likely the cause.

Suggested fix:

Create some global variables and read any mouse states and other required input ONCE inside your program's main loop.

Either reference the global variables directly from your Run_SLots function or pass them over as function parameters.

Omnicode

(Posted 2013) [#5]

Thank you both, I read both of your responses and I hope to combine. That bit of info about flip being the point in which mousehit actually updates is a complete break through for me.
Here's just a pic to give some imagery.

Btw. Mis-communication on my part when I said layered I meant this as a metaphor for the issue. Basically what I had meant was it seemed like (from what I could tell as I beta test my game constantly) the first slot could be selected and registered faster, the last slot was almost impossible so on and so forth so i built this idea in my head that was rather false, sorry. I do believe the claim of the multitude of mouse checks is the primary issue and should indeed be handled by yet another set of globals. I just wanted to optimize everything before I release anything so the claim of compiling into a function for variable calls is genius thank you for that bit. I hope to repost my fixed version quite soon. Also, if you wish to keep updated with progress, I have a worklog that I will use to chart its dev.
Thanks for your time.

Also, I'm not really a beginner to blitz3d. Just needed some input. As none of my friends are code suave.

Kryzon

(Posted 2013) [#6]

It is Blitz's Flip() command that is actually responsible for updating mouse and keyboard events via Windows PeekMessage function so the above is most likely the cause.

I agree that storing the keyboard\mouse state once per frame is the best approach, but are you sure about this Flip thing?
The MouseHit() sample code doesn't make use of Flip, and still reports the amount of clicks with success.

MCP	(Posted 2013) [#7]

I assume you mean this example from the blitz3d docs...

; MouseHit Example

; Set up the timer
current=MilliSecs()
Print "Press left mouse button a bunch of times for five seconds..."

; Wait 5 seconds
While MilliSecs() < current+5000
Wend

; Print the results
Print "Pressed left button " + MouseHit(1) + " times."

The reason the above example works without Flip() is because it compiles to a stock console application where internal events and outputs are handled differently.
When using Graphics3D() as intended for games blitz3d actually compiles a Windows application and sets up a Direct3d interface. Output is directed to the backbuffer and Flip() is required to swap the backbuffer with the frontbuffer as you'd expect. Windows messaging is also handled by the Flip command via the PeekMessage loop described in my original post to keep Windows happy and update the Blitz event system.

Kryzon

(Posted 2013) [#8]

Try the following (it uses Graphics3D):

Graphics3D 800,600,0,2 ;Windowed or fullscreen give the same result.

current=MilliSecs()
Print "Press left mouse button a bunch of times for five seconds..."

; Wait 5 seconds
While MilliSecs() < current+5000
Wend

; Print the results
Print "Pressed left button " + MouseHit(1) + " times."
WaitKey()
End

It still reports the hits for me, even though it makes no use of Flip. It must poll the keyboard\mouse by use of an internal timer or something else - maybe Yasha knows.

MCP	(Posted 2013) [#9]

The only thing I can think of there is that mouse events are being fed through Blitz's winproc() procedure and mousehit is actually being updated through that so yes by the time your code does query mousehit it will contain the correct number of hits. A tool similar to Winspy++ should answer that.
As a side note blitz3d could also insert default message processing in the absence of flip() or that maybe something that the system handles in the absence of getmessage,peek message in an app. That's something I'll have to look into. I still stand by my original claim though as I've done a lot of 'low level' work extending blitz3d in the past.

Omnicode

(Posted 2013) [#10]

Hello again, Im proud to announce I successfully fixed the issue :D

What I basically did was completely replace the use of my mousehits within any function and instead ran them all on a Global function named: Mouse_Checks() used to check for mousehits(1-2) and downs(1-2): works faster than ever! Thank you guys for your help, it inspired me to continue on and crack such a mind-blogging issue i've had since the creation of the inventory system. :D

Ill edit in a video if i can to show the speed and optimization shortly!
Old Method:
https://www.youtube.com/watch?v=ncrR5cFdddY

New Method:
https://www.youtube.com/watch?v=p8VQL0qwXHE

MCP	(Posted 2013) [#11]

Congrats. That's a big improvement :)

Omnicode

(Posted 2013) [#12]

Thanks :D

RemiD

(Posted 2013) [#13]

Hello Omnicode,

I just wanted to say that i like how your project is progressing, i hope you will manage to finish it or at least to finish a demo.

I like the renders with these simple graphics, it reminds me of Daggerfall and Morrowind. :)

I wish you the best for the next steps.

Omnicode

(Posted 2013) [#14]

Thanks! it means more than you know.
I do as well, if you wish to follow my progress just check out my work-logs. Ill be sure to post a new update after every 2-3days. Right now im currently re-working all Ai within my game as it was rather retro and dull.

Omnicode

(Posted 2013) [#15]

This prior coding of the inventory has become obsolete, I've since replaced the inventory system with a far faster, and efficient system that can provide more with less.
Features: Stack-Splitting, Dragging, Use-To-Use Item recipes, Tools, Handles multiple bags for in-game banking or something like that.

Last Inventory was 430 Lines.
New Inventory is 260 Lines.