Event Suspend Bug? - Please Test

Archives Forums/BlitzMax Bug Reports/Event Suspend Bug? - Please Test

therevills

(Posted 2009) [#1]

Hi all,

Ive noticed what could be a slight bug with EVENT_APPSUSPEND.

Please try this code:

SuperStrict

Graphics 640,480,0

Extern "win32"
	Function GetActiveWindow%()
End Extern

Global suspended% = 0
Global windowHandle%=0

WindowHandle = GetActiveWindow()
addMinimize(WindowHandle)

Const freq:Int=44100
Const updatespeed:Int=10
Const buffersize:Int=freq/updatespeed

Local buffer:TAudioSample[2]
buffer[0]=CreateAudioSample(buffersize,freq,SF_STEREO16BE)
buffer[1]=CreateAudioSample(buffersize,freq,SF_STEREO16BE)

Global sound:TSound[2]
sound[0]=LoadSound(buffer[0])
sound[1]=LoadSound(buffer[1])

While Not KeyHit(KEY_ESCAPE)
	peek()
	If Not suspended
		game()
	Else
		Cls
		SetColor 255,255,255
		DrawText "PAUSED", 100, 100
	EndIf
	Flip	
Wend

Function game()
	PlaySound sound[0]
	Cls
	For Local i% = 0 To 1000
		SetColor Rand(0,255),Rand(0,255),Rand(0,255)
		Plot Rand(0,640),Rand(0,480)
	Next
	PlaySound sound[1]
End Function

Function peek()
	While PeekEvent()
		PollEvent()
		Select EventID()
			Case EVENT_APPSUSPEND
			  	suspended = 1
			Case EVENT_APPRESUME
		  		suspended = 0
		End Select
	Wend
End Function

Function addMinimize(hWnd:Long)
	Local tmp:Long = GetWindowLongA( hWnd, GWL_STYLE )
	tmp = tmp | WS_MINIMIZEBOX
	SetWindowLongA( hWnd, GWL_STYLE, tmp )
	DrawMenuBar( hWnd )
End Function

When running, click off the window and the display should says "PAUSED" and the sound should stop.

Okay, now click on the window, the pixels should redraw and the sound will start again.

Now click the minimise button and the sound should stop.

Click the taskbar icon, this will maximise the window, and the sound starts.

Now the bug, click the taskbar icon, the game minimises and the sound still plays, so the "game" is still playing...

Im testing this on Windows 7 RC1.

Thanks

Jur	(Posted 2009) [#2]

Yes, the same on Vista.

therevills

(Posted 2009) [#3]

Thanks for testing it Jur.

Should this be moved into the Bug forum?

SebHoll

(Posted 2009) [#4]

Confirmed on my Vista PC too. Had a look into this for you guys, and it seems to be a common problem people experience when minimizing in this way. The fix is to handle the WM_ACTIVATE message instead of WM_ACTIVATEAPP.

Try replacing the WM_ACTIVATEAPP case in BlitzMax/mod/brl.mod/system.mod/system.win32.c's bbSystemEmitOsEvent() with...

	case WM_ACTIVATE:
		GetWindowThreadProcessId( lp, &lpdwProcessId );
		if(!((LOWORD(wp)!=WA_INACTIVE) && IsIconic(hwnd)) && lpdwProcessId!=GetCurrentProcessId())
			id = (LOWORD(wp) == WA_INACTIVE) ? BBEVENT_APPSUSPEND : BBEVENT_APPRESUME;
		else
			return;
		break;

Then add the following variable declaration to the top of that function:

	LPDWORD lpdwProcessId = NULL;

...and build modules.

Let me know if it works for you too. I've tested this with the latest MaxGUI and with multiple windows and it appears to work as expected.

marksibly

(Posted 2009) [#5]

Hi,

To be honest, I am uncomfortable with the idea of 'supporting' SetWindowLong style hacks like this.

However, being able to minimize graphics is obviously a popular feature request, so I'll have a go at implementing it directly into Max in a nice cross-platform way soon.

SebHoll

(Posted 2009) [#6]

I am uncomfortable with the idea of 'supporting' SetWindowLong style hacks like this.

This bug is also visible, though, with MaxGUI apps when windows are minimized in this way.

being able to minimize graphics is obviously a popular feature request, so I'll have a go at implementing it directly into Max in a nice cross-platform way soon

Cool!

marksibly

(Posted 2009) [#7]

Hi,

> This bug is also visible, though, with MaxGUI apps when windows are minimized in this way.

Well, I'm not sure minimizing a window *should* necessarily generate an suspend event - can't app remain 'active' even with a minimized main window?

In the case of single window 'graphics' apps like the above, I think it makes sense for suspend to be triggered, but I'm not sure about 'real' GUI apps.

SebHoll

(Posted 2009) [#8]

Well, I'm not sure minimizing a window *should* necessarily generate an suspend event - can't app remain 'active' even with a minimized main window?

The if statements are there to make sure it's only emitted when focus is given to a window or control in another process/application - i.e. when the *app* has loss focus. I was under the impression this was supposed to be when EVENT_APPSUSPEND was supposed to be triggered.

plash

(Posted 2009) [#9]

being able to minimize graphics is obviously a popular feature request, so I'll have a go at implementing it directly into Max in a nice cross-platform way soon

Awesome. I was thinking of this just the other day.

In the case of single window 'graphics' apps like the above, I think it makes sense for suspend to be triggered, but I'm not sure about 'real' GUI apps.

That seems correct to me.. The programmer will be dealing with the event however he wishes, so I don't think it would hurt to send the event in both cases (unless there's something else that happens when the event is sent, in that case, I'd leave that up to a special event for MaxGUI).

therevills

(Posted 2009) [#10]

Looks like this is fixed in 1.35 :)

Thanks Mark!